Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trezor: replace Python tools with CMake #9477

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

tobtoht
Copy link
Collaborator

@tobtoht tobtoht commented Sep 12, 2024

As a result, we can remove Python from the release build environment.

Fixes #9524.

Copy link
Collaborator

@0xFFFC0000 0xFFFC0000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is a draft. But code LGTM and very badly needed to get rid of PythonTools.

Thank you for working on this.

@sneurlax
Copy link
Contributor

Yes PLEASE, PythonTools have been a pain point for me when poking around Trezor code. Concept ACK, code looks good

@tobtoht tobtoht force-pushed the trezor_py branch 2 times, most recently from abf250c to 655544a Compare December 24, 2024 18:14
@tobtoht tobtoht marked this pull request as ready for review December 24, 2024 20:41
@tobtoht tobtoht merged commit 2a9458a into monero-project:master Jan 14, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to build docker image
5 participants