Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Tab and setting to upload mobilcss rules #205

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Added Tab and setting to upload mobilcss rules #205

merged 2 commits into from
Jan 31, 2023

Conversation

NinaHerrmann
Copy link
Collaborator

@NinaHerrmann NinaHerrmann commented Jan 24, 2023 •
edited
Loading

Implements #195 (Add tab mobile and text field setting to add css to mobile layout).

grafik
grafik

@NinaHerrmann NinaHerrmann force-pushed the feature/uploadrawmobilecss branch 5 times, most recently from aae00b0 to 0ef5be2 Compare January 24, 2023 13:21
@abias abias self-requested a review January 25, 2023 12:43
@NinaHerrmann NinaHerrmann force-pushed the feature/uploadrawmobilecss branch from 131ec3a to c034242 Compare January 27, 2023 16:59
@abias abias mentioned this pull request Jan 30, 2023
Open
abias
abias requested changes Jan 30, 2023
View reviewed changes
Copy link
Member

@abias abias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Nina,

many thanks for working on this issue!

As with the previous PRs from you, I have reviewed it thoroughly and have added several comments to the code. But I will go ahead and will fix all items directly within my review work.
I will also do some more improvements regarding whitespace and some other prettyfications.

If the tests pass again, the PR can be merged.

Cheers,
Alex

CHANGES.md Outdated Show resolved Hide resolved
settings.php Show resolved Hide resolved
settings.php Outdated Show resolved Hide resolved
settings.php Outdated Show resolved Hide resolved
settings.php Outdated Show resolved Hide resolved
locallib.php Outdated Show resolved Hide resolved
locallib.php Outdated Show resolved Hide resolved
locallib.php Outdated Show resolved Hide resolved
locallib.php Outdated Show resolved Hide resolved
tests/behat/theme_boost_union_looksettings_mobile.feature Outdated Show resolved Hide resolved
@abias abias force-pushed the feature/uploadrawmobilecss branch 2 times, most recently from d4b577c to 9215d03 Compare January 31, 2023 06:16
@abias
Copy link
Member

abias commented Jan 31, 2023

Tests are passing again now.

However, I want to have a look at one thing before I merge this:
Caching of the CSS file in the Mobile app

@abias abias force-pushed the feature/uploadrawmobilecss branch from 9215d03 to b086a6e Compare January 31, 2023 19:47
@abias
Copy link
Member

abias commented Jan 31, 2023

I just added a rev parameter to the styles.php URL which holds the unix timestamp of the time when the CSS code setting was saved for the last time. Afterwards, I have tested it in the Mobile App with a Premium subscription (to allow basic app branding at all).

The new CSS code was loaded and applied by the app at each fresh login. This is fine.

As soon as the tests pass another time, this will be merged.

@abias abias merged commit 8dd7210 into moodle-an-hochschulen:master Jan 31, 2023
@abias abias mentioned this pull request Jan 31, 2023
Closed
detomon pushed a commit to detomon/moodle-theme_boost_union that referenced this pull request Aug 26, 2024
@abias
Merge pull request moodle-an-hochschulen#205 from NinaHerrmann/featur…
d9c41cd 
…e/uploadrawmobilecss

Added Tab and setting to upload mobilcss rules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abias abias abias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NinaHerrmann @abias