Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid PHP error with BoilerplateComment and empty files #100

Merged

Conversation

stronk7
Copy link
Member

@stronk7 stronk7 commented Feb 13, 2024

Covered with a specific new test.

Fixes #97

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4f7f6d6) 96.61% compared to head (3629cb2) 96.61%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #100   +/-   ##
=========================================
  Coverage     96.61%   96.61%           
- Complexity      538      539    +1     
=========================================
  Files            23       23           
  Lines          1538     1538           
=========================================
  Hits           1486     1486           
  Misses           52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stronk7 stronk7 force-pushed the boilerplate_sniff_and_empty_files branch from 6bf670a to d2dc105 Compare February 14, 2024 07:54
@stronk7 stronk7 added the bug Something isn't working label Feb 15, 2024
@stronk7 stronk7 force-pushed the boilerplate_sniff_and_empty_files branch from d2dc105 to 3629cb2 Compare February 15, 2024 08:56
@stronk7 stronk7 requested a review from junpataleta February 15, 2024 08:59
Copy link
Contributor

@junpataleta junpataleta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @stronk7 ! Looking good now.

@junpataleta junpataleta merged commit 52e5f08 into moodlehq:main Feb 15, 2024
8 checks passed
@stronk7 stronk7 deleted the boilerplate_sniff_and_empty_files branch February 15, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

moodle.Files.BoilerplateComment fails on empty files
2 participants