-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sniff to detect missing docs for constants #129
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewnicols
force-pushed
the
constantsDocumentedCheck
branch
from
March 22, 2024 14:43
89a73f3
to
afab910
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #129 +/- ##
============================================
+ Coverage 97.82% 97.84% +0.02%
- Complexity 826 835 +9
============================================
Files 36 36
Lines 2432 2463 +31
============================================
+ Hits 2379 2410 +31
Misses 53 53 ☔ View full report in Codecov by Sentry. |
andrewnicols
added a commit
to andrewnicols/moodle-local_moodlecheck
that referenced
this pull request
Mar 22, 2024
Replaced by moodlehq/moodle-cs#129
andrewnicols
added a commit
to andrewnicols/moodle-local_moodlecheck
that referenced
this pull request
Mar 22, 2024
andrewnicols
added a commit
to andrewnicols/moodle-local_moodlecheck
that referenced
this pull request
Mar 22, 2024
24 tasks
andrewnicols
added a commit
to andrewnicols/moodle-local_moodlecheck
that referenced
this pull request
Mar 22, 2024
andrewnicols
force-pushed
the
constantsDocumentedCheck
branch
from
March 23, 2024 13:05
afab910
to
fbe6264
Compare
stronk7
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces constsdocumented check.
moodlehq/moodle-local_moodlecheck#140