Revert "Pick the PHPCSExtra CommaAfterLastSniff Sniff to moodle" #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stronk7
force-pushed
the
back_to_upstream_comma_after_last
branch
from
ee2caef to
3600841
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
============================================
+ Coverage 96.17% 96.46% +0.29%
+ Complexity 543 517 -26
============================================
Files 23 22 -1
Lines 1542 1471 -71
============================================
- Hits 1483 1419 -64
+ Misses 59 52 -7 ☔ View full report in Codecov by Sentry. |
stronk7
force-pushed
the
back_to_upstream_comma_after_last
branch
2 times, most recently
from
fe954c3 to
04f4352
Compare
andrewnicols
approved these changes
Dec 5, 2023
This reverts commit 1c295bb Now that PHPCSExtra 1.2.0 has been released, we can revert this commit and switch back to use the upstream Sniff. A few more modifications (composer...) come to point to the new PHPCSExtra version. Fixes moodlehq#82
andrewnicols
force-pushed
the
back_to_upstream_comma_after_last
branch
from
04f4352 to
0895682
Compare
|
Drat, I removed my branches thinking that I saw this one merged! Grrr (2nd time it happens to me) I'm going to cherry pick 0895682 on top of main and done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 1c295bb.
Now that PHPCSExtra 1.2.0 has been released, we can revert this commit and switch back to use the upstream Sniff.
A few more modifications (composer...) come to point to the new PHPCSExtra version.
Fixes #82