Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enums do not have side effects #95

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

andrewnicols
Copy link
Contributor

Add support for ENUMs to the MoodleInternal sniff

@andrewnicols andrewnicols requested a review from stronk7 February 5, 2024 01:57
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ec45d66) 96.58% compared to head (525a457) 96.59%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #95      +/-   ##
============================================
+ Coverage     96.58%   96.59%   +0.01%     
  Complexity      536      536              
============================================
  Files            23       23              
  Lines          1521     1527       +6     
============================================
+ Hits           1469     1475       +6     
  Misses           52       52              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stronk7 stronk7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect, and covered, hence, sold!

Thanks!

@stronk7 stronk7 merged commit 9f0b0c1 into moodlehq:main Feb 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants