Allow comments followed by an attribute #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
============================================
+ Coverage 96.59% 96.61% +0.01%
- Complexity 536 537 +1
============================================
Files 23 23
Lines 1527 1536 +9
============================================
+ Hits 1475 1484 +9
Misses 52 52 ☔ View full report in Codecov by Sentry. |
stronk7
approved these changes
Feb 5, 2024
Per PER-2.0: > If a comment docblock is present on a structure that also includes an > attribute, the comment block MUST come first, followed by any > attributes, followed by the structure itself. There MUST NOT be any > blank lines between the docblock and attributes, or the attributes and > the structure. https://www.php-fig.org/per/coding-style/#122-placement Other more attribute-specific Sniffs should test for Attributes and their correctness, but this comment sniff should not add false positives.
stronk7
force-pushed
the
inlineCommentForAttribute
branch
from
9175489 to
5b915e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per PER-2.0:
https://www.php-fig.org/per/coding-style/#122-placement
Other more attribute-specific Sniffs should test for Attributes and their correctness, but this comment sniff should not add false positives.