Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for running ci against main Moodle branch #37

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Fixes for running ci against main Moodle branch #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1bf70e4
Moodle master branch was renamed to main
danowar2k Jan 17, 2025
fb373d8
Moodle main branch now requires Postgres 14
danowar2k Jan 17, 2025
6c0901b
phpcs should only test up to the matrix php version
danowar2k Jan 17, 2025
3923d3c
ci - check Moodle 4.1 with PHP 8.1
danowar2k Jan 17, 2025
968a091
Behat tests use qtype_recordrtc
danowar2k Jan 17, 2025
d83fdf6
Forgot organization
danowar2k Jan 17, 2025
01d4aea
Added dependency for qtype_recordrtc to install
danowar2k Jan 17, 2025
d6ee9df
Immediate Feedback behaviour outputs a button labeled "Check", not "S…
danowar2k Jan 17, 2025
5bce2b9
Dump behat failures
danowar2k Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:

services:
postgres:
image: postgres:13
image: postgres:14
env:
POSTGRES_USER: 'postgres'
POSTGRES_HOST_AUTH_METHOD: 'trust'
Expand All @@ -31,11 +31,14 @@ jobs:
matrix:
include:
- php: '8.2'
moodle-branch: 'master'
moodle-branch: 'main'
database: 'pgsql'
- php: '8.1'
moodle-branch: 'MOODLE_402_STABLE'
database: 'mariadb'
- php: '8.1'
moodle-branch: 'MOODLE_401_STABLE'
database: 'pgsql'
- php: '8.0'
moodle-branch: 'MOODLE_401_STABLE'
database: 'pgsql'
Expand Down Expand Up @@ -69,6 +72,8 @@ jobs:

- name: Install moodle-plugin-ci
run: |
moodle-plugin-ci add-plugin moodleou/moodle-qbehaviour_selfassess
moodle-plugin-ci add-plugin moodleou/moodle-qtype_recordrtc
moodle-plugin-ci install --plugin ./plugin --db-host=127.0.0.1
env:
DB: ${{ matrix.database }}
Expand All @@ -89,7 +94,7 @@ jobs:

- name: Moodle Code Checker
if: ${{ always() }}
run: moodle-plugin-ci phpcs --max-warnings 0
run: moodle-plugin-ci phpcs --test-version ${{ matrix.php }} --max-warnings 0

- name: Moodle PHPDoc Checker
if: ${{ always() }}
Expand Down Expand Up @@ -117,4 +122,4 @@ jobs:

- name: Behat features
if: ${{ always() }}
run: moodle-plugin-ci behat --profile chrome
run: moodle-plugin-ci behat --profile chrome --dump
4 changes: 2 additions & 2 deletions tests/behat/filter_embedquestion.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ Feature: Add an activity and embed a question inside that activity
And I should see "The answer is true."

@javascript
Scenario: Test display of Save button for embedded recordrtc question.
Scenario: Test display of Check button for embedded recordrtc question.
Given the following "questions" exist:
| questioncategory | qtype | name | idnumber | template |
| Test questions | recordrtc | Record AV question | test1 | audio |
Expand All @@ -122,4 +122,4 @@ Feature: Add an activity and embed a question inside that activity
And I set the field "How the question behaves" to "Immediate feedback"
And I press "Embed question"
And I switch to "filter_embedquestion-iframe" iframe
And I should see "Save"
And I should see "Check"