fix(metadata-hash): use original token symbol (DEV) in moonbase runtime #3015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomarQ
added
B0-silent
WASM runtime size check:Compared to target branchMoonbase runtime: 2260 KB (no changes) ✅ Moonbeam runtime: 2228 KB (no changes) ✅ Moonriver runtime: 2232 KB (no changes) ✅ Compared to latest release (runtime-3300)Moonbase runtime: 2260 KB (+232 KB compared to latest release) Moonbeam runtime: 2228 KB (+232 KB compared to latest release) Moonriver runtime: 2232 KB (+240 KB compared to latest release) |
Agusrodri
approved these changes
Oct 16, 2024
ahmadkaouk
approved these changes
Oct 16, 2024
Coverage Report@@ Coverage Diff @@
## master rq/fix-moonbase-metadata-hash +/- ##
================================================================
Coverage 79.01% 79.01% 0.00%
Files 305 305
Lines 88446 88446
================================================================
Hits 69878 69878
Misses 18568 18568
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Uses the original moonbase token symbol when using
metadata-hashtransaction extension.The original token symbol used in moonbase is
DEVand notUNIT. When leveraging metadata hash, the token symbol is included in the metadata digest and would cause the transaction to fail.What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?