Foreign Assets Migration

[ahmadkaouk]

What does it do?

This PR is a follow up of #2869 , it manage the migration of existing foreign assets to the new design. The PR introduces five extrinsics in pallet-moonbeam-lazy-migration to handle the migration of a foreign asset.

approve_assets_to_migrate

• Sets the list of asset id for assets approved for migration
• Allowed origins: FastGeneralAdmin, 5/9 of OpenTechCommittee, Root

start_foreign_asset_migration

• Initiates migration for a specific foreign asset
• Freezes the original asset to prevent further transactions
• Creates new EVM smart contract via the new moonbeam-foreign-assets pallet
• Stores migration state including remaining balances and approvals count

migrate_foreign_asset_balances

• Migrates asset balances in batches (controlled by limit parameter)
• Drains balances from old assets pallet
• Mints equivalent amounts in new foreign assets system
• Updates remaining balances counter

migrate_foreign_asset_approvals

• Migrates asset approvals in batches (controlled by limit parameter)
• Drains approvals from old assets pallet
• Creates equivalent approvals in new foreign assets system
• Unreserves deposits from old approval system
• Updates remaining approvals counter

finish_foreign_asset_migration

• Completes migration after all balances and approvals are migrated
• Performs final cleanup of old asset storage
• Unreserves deposits from asset creation and metadata

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

[github-actions]

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2268 KB (no changes) ✅

Moonbeam runtime: 2248 KB (no changes) ✅

Moonriver runtime: 2252 KB (no changes) ✅

Compared to latest release (runtime-3300)

Moonbase runtime: 2268 KB (+240 KB compared to latest release) ⚠️

Moonbeam runtime: 2248 KB (+252 KB compared to latest release) ⚠️

Moonriver runtime: 2252 KB (+260 KB compared to latest release) ⚠️

[github-actions]

Coverage Report

@@                        Coverage Diff                         @@
##           master   ahmad-foreign-assets-migration      +/-   ##
==================================================================
- Coverage   74.70%                           74.44%   -0.26%     
+ Files         369                              375       +6     
+ Lines       94308                            95766    +1458     
==================================================================
+ Hits        70446                            71284     +838     
+ Misses      23862                            24482     +620     

Files Changed	Coverage
/client/rpc/dev/src/lib.rs	49.40% (-39.76%)	🔽
/client/rpc/finality/src/lib.rs	12.50% (-68.75%)	🔽
/client/rpc-core/txpool/src/types/content.rs	68.52% (-1.85%)	🔽
/client/rpc-core/txpool/src/types/inspect.rs	88.46% (-3.85%)	🔽
/pallets/moonbeam-foreign-assets/src/evm.rs	74.02% (+3.24%)	🔼
/pallets/moonbeam-foreign-assets/src/lib.rs	74.82% (+3.97%)	🔼
/pallets/moonbeam-lazy-migrations/src/lib.rs	80.65% (-1.39%)	🔽
/pallets/moonbeam-lazy-migrations/src/mock.rs	67.86% (-7.90%)	🔽
/pallets/moonbeam-lazy-migrations/src/tests.rs	98.15% (-1.12%)	🔽

Coverage generated Wed Dec 4 09:10:07 UTC 2024

[RomarQ]

Added a few remarks, but overall looks good. Great work 🚀

[gonzamontiel]

With the addition of being able to migrate several foreign assets at the same time, It looks good to me, great work!