-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to polkadot stable2409 #3031
Conversation
WASM runtime size check:Compared to target branchMoonbase runtime: 2288 KB (no changes) ✅ Moonbeam runtime: 2260 KB (no changes) ✅ Moonriver runtime: 2244 KB (no changes) ✅ Compared to latest release (runtime-3400)Moonbase runtime: 2288 KB (+260 KB compared to latest release) Moonbeam runtime: 2260 KB (+248 KB compared to latest release) Moonriver runtime: 2244 KB (+232 KB compared to latest release) |
test/suites/dev/moonbase/test-storage-growth/test-precompile-storage-growth.ts
Outdated
Show resolved
Hide resolved
The cherry-picks for |
# Conflicts: # Cargo.lock # pallets/moonbeam-foreign-assets/src/evm.rs # pallets/moonbeam-lazy-migrations/src/mock.rs # test/suites/dev/moonbase/test-precompile/test-precompile-proxy.ts # test/suites/dev/moonbase/test-randomness/test-randomness-babe-lottery2.ts # test/suites/dev/moonbase/test-randomness/test-randomness-babe-lottery3.ts # test/suites/dev/moonbase/test-randomness/test-randomness-vrf-lottery4.ts # test/suites/dev/moonbase/test-randomness/test-randomness-vrf-lottery5.ts
test/suites/dev/moonbase/test-storage-growth/test-precompile-storage-growth.ts
Outdated
Show resolved
Hide resolved
test/suites/dev/moonbase/test-storage-growth/test-precompile-storage-growth.ts
Outdated
Show resolved
Hide resolved
test/suites/dev/moonbase/test-storage-growth/test-precompile-storage-growth.ts
Outdated
Show resolved
Hide resolved
Hi @TarekkMA, can you add to the description the frontier commit that increased the gas costs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Also, @TarekkMA can you update the breaking changes section if the description? |
fixes #2994
What does it do?
Upgrade from
stable2407
tostable2409
What important points reviewers should know?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
Below are the used forks, please review that cherrypicks have been applied correctly.
Evm
: https://github.com/moonbeam-foundation/evm/tree/moonbeam-polkadot-stable2409Frontier
: https://github.com/moonbeam-foundation/frontier/tree/moonbeam-polkadot-stable2409Polkadot SDK
: https://github.com/moonbeam-foundation/polkadot-sdk/tree/moonbeam-polkadot-stable2409Crowdloan rewards
: https://github.com/moonbeam-foundation/crowdloan-rewards/tree/moonbeam-polkadot-stable2409Moonkit
: https://github.com/Moonsong-Labs/moonkit/tree/moonbeam-polkadot-stable2409ACCOUNT_BASIC_PROOF_SIZE
was increased which resulted in gas cost increase.