Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to polkadot stable2409 #3031

Merged
merged 48 commits into from
Dec 20, 2024
Merged

Upgrade to polkadot stable2409 #3031

merged 48 commits into from
Dec 20, 2024

Conversation

TarekkMA
Copy link
Contributor

@TarekkMA TarekkMA commented Nov 6, 2024

fixes #2994

What does it do?

Upgrade from stable2407 to stable2409

What important points reviewers should know?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

Below are the used forks, please review that cherrypicks have been applied correctly.

⚠️ Breaking Changes ⚠️

@TarekkMA TarekkMA marked this pull request as draft November 6, 2024 08:30
Copy link
Contributor

github-actions bot commented Nov 6, 2024

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2288 KB (no changes) ✅

Moonbeam runtime: 2260 KB (no changes) ✅

Moonriver runtime: 2244 KB (no changes) ✅

Compared to latest release (runtime-3400)

Moonbase runtime: 2288 KB (+260 KB compared to latest release) ⚠️

Moonbeam runtime: 2260 KB (+248 KB compared to latest release) ⚠️

Moonriver runtime: 2244 KB (+232 KB compared to latest release) ⚠️

@TarekkMA TarekkMA self-assigned this Nov 6, 2024
@TarekkMA TarekkMA linked an issue Nov 6, 2024 that may be closed by this pull request
@TarekkMA TarekkMA added B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Nov 8, 2024
@TarekkMA TarekkMA marked this pull request as ready for review November 20, 2024 11:23
@RomarQ
Copy link
Contributor

RomarQ commented Dec 2, 2024

The cherry-picks for moonbeam-polkadot-stable2409 need to be reviewed carefully, frontier was missing a few.

# Conflicts:
#	Cargo.lock
#	pallets/moonbeam-foreign-assets/src/evm.rs
#	pallets/moonbeam-lazy-migrations/src/mock.rs
#	test/suites/dev/moonbase/test-precompile/test-precompile-proxy.ts
#	test/suites/dev/moonbase/test-randomness/test-randomness-babe-lottery2.ts
#	test/suites/dev/moonbase/test-randomness/test-randomness-babe-lottery3.ts
#	test/suites/dev/moonbase/test-randomness/test-randomness-vrf-lottery4.ts
#	test/suites/dev/moonbase/test-randomness/test-randomness-vrf-lottery5.ts
@TarekkMA TarekkMA marked this pull request as draft December 17, 2024 11:15
@TarekkMA TarekkMA marked this pull request as ready for review December 17, 2024 12:58
@RomarQ
Copy link
Contributor

RomarQ commented Dec 19, 2024

Hi @TarekkMA, can you add to the description the frontier commit that increased the gas costs?

Copy link
Contributor

@RomarQ RomarQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RomarQ
Copy link
Contributor

RomarQ commented Dec 19, 2024

Also, @TarekkMA can you update the breaking changes section if the description?

@TarekkMA TarekkMA merged commit 7dbae97 into master Dec 20, 2024
47 checks passed
@TarekkMA TarekkMA deleted the moonbeam-polkadot-stable2409 branch December 20, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update polkadot-sdk from stable2407 to stable2409
4 participants