Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(smoke): use valid moonriver transaction for runtime 1605 #3044

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

RomarQ
Copy link
Contributor

@RomarQ RomarQ commented Nov 13, 2024

What does it do?

Unblocks the following PR: https://github.com/moonbeam-foundation/moonbeam-smoke-tests-moonwall-config/pull/66

What important points reviewers should know?

Transactions included in block 2077599 were duplicated in block 2077600, which causes the tracing of these transactions to fail.

The issue is documented here:
Historical Updates | Moonbeam Docs

@RomarQ RomarQ added I4-tests 🎯 Tests need fixing, improving or augmenting. D2-notlive PR doesn't change runtime code (so can't be audited) not-breaking Does not need to be mentioned in breaking changes labels Nov 13, 2024
@RomarQ RomarQ self-assigned this Nov 13, 2024
Copy link
Contributor

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2260 KB (no changes) ✅

Moonbeam runtime: 2228 KB (no changes) ✅

Moonriver runtime: 2232 KB (no changes) ✅

Compared to latest release (runtime-3300)

Moonbase runtime: 2260 KB (+232 KB compared to latest release) ⚠️

Moonbeam runtime: 2228 KB (+232 KB compared to latest release) ⚠️

Moonriver runtime: 2232 KB (+240 KB compared to latest release) ⚠️

Copy link
Contributor

Coverage Report

@@                Coverage Diff                @@
##           master   rq/fix-S15C003     +/-   ##
=================================================
  Coverage   79.00%           79.00%   0.00%     
  Files         305              305             
  Lines       88458            88458             
=================================================
  Hits        69878            69878             
  Misses      18580            18580             
Files Changed Coverage

Coverage generated Wed Nov 13 12:37:13 UTC 2024

@RomarQ RomarQ added the B0-silent Changes should not be mentioned in any release notes label Nov 13, 2024
@RomarQ RomarQ marked this pull request as ready for review November 13, 2024 12:57
@RomarQ RomarQ merged commit d184125 into master Nov 13, 2024
43 of 47 checks passed
@RomarQ RomarQ deleted the rq/fix-S15C003 branch November 13, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited) I4-tests 🎯 Tests need fixing, improving or augmenting. not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants