Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fetch correct runtime release commit #3046

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

RomarQ
Copy link
Contributor

@RomarQ RomarQ commented Nov 16, 2024

What does it do?

Fixes CI, by using the correct latest release commit.

@RomarQ RomarQ added I4-tests 🎯 Tests need fixing, improving or augmenting. D2-notlive PR doesn't change runtime code (so can't be audited) not-breaking Does not need to be mentioned in breaking changes labels Nov 16, 2024
@RomarQ RomarQ self-assigned this Nov 16, 2024
@RomarQ RomarQ requested review from a team as code owners November 16, 2024 09:03
@RomarQ RomarQ added the B0-silent Changes should not be mentioned in any release notes label Nov 16, 2024
Copy link
Contributor

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2264 KB (no changes) ✅

Moonbeam runtime: 2228 KB (no changes) ✅

Moonriver runtime: 2232 KB (no changes) ✅

Compared to latest release (runtime-3300)

Moonbase runtime: 2264 KB (+236 KB compared to latest release) ⚠️

Moonbeam runtime: 2228 KB (+232 KB compared to latest release) ⚠️

Moonriver runtime: 2232 KB (+240 KB compared to latest release) ⚠️

Copy link
Contributor

Coverage Report

@@                         Coverage Diff                          @@
##           master   rq/use-correct-docker-image-in-ci     +/-   ##
====================================================================
  Coverage   79.00%                              79.00%   0.00%     
  Files         305                                 305             
  Lines       88470                               88470             
====================================================================
  Hits        69890                               69890             
  Misses      18580                               18580             
Files Changed Coverage

Coverage generated Sat Nov 16 09:38:42 UTC 2024

@RomarQ RomarQ merged commit 8455090 into master Nov 18, 2024
44 of 49 checks passed
@RomarQ RomarQ deleted the rq/use-correct-docker-image-in-ci branch November 18, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited) I4-tests 🎯 Tests need fixing, improving or augmenting. not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants