Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test XCM transfer and pay fees with foreign asset #3047

Merged
merged 20 commits into from
Nov 25, 2024

Conversation

gonzamontiel
Copy link
Contributor

We test that an account in some parachain, can transfer some foreign assets to an account in Moonbeam, paying in another foreign asset. So that they don't need to buy GLMR for buying time for the execution.

@gonzamontiel gonzamontiel added B0-silent Changes should not be mentioned in any release notes not-breaking Does not need to be mentioned in breaking changes D2-notlive PR doesn't change runtime code (so can't be audited) labels Nov 18, 2024
Copy link
Contributor

github-actions bot commented Nov 18, 2024

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2260 KB (no changes) ✅

Moonbeam runtime: 2232 KB (no changes) ✅

Moonriver runtime: 2236 KB (no changes) ✅

Compared to latest release (runtime-3300)

Moonbase runtime: 2260 KB (+232 KB compared to latest release) ⚠️

Moonbeam runtime: 2232 KB (+236 KB compared to latest release) ⚠️

Moonriver runtime: 2236 KB (+244 KB compared to latest release) ⚠️

Copy link
Contributor

github-actions bot commented Nov 18, 2024

Coverage Report

@@                           Coverage Diff                           @@
##           master   gonza/test-xcm-transfer-and-pay-fees     +/-   ##
=======================================================================
  Coverage   74.75%                                 74.75%   0.00%     
  Files         369                                    369             
  Lines       94211                                  94211             
=======================================================================
  Hits        70424                                  70424             
  Misses      23787                                  23787             
Files Changed Coverage

Coverage generated Mon Nov 25 00:25:11 UTC 2024

@gonzamontiel gonzamontiel changed the title Test xcm transfer and pay fees Test xcm transfer and pay fees with foreign asset Nov 21, 2024
@gonzamontiel gonzamontiel changed the title Test xcm transfer and pay fees with foreign asset Test XCM transfer and pay fees with foreign asset Nov 21, 2024
Copy link
Contributor

@Agusrodri Agusrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gonzamontiel gonzamontiel merged commit c6d07d7 into master Nov 25, 2024
39 checks passed
@gonzamontiel gonzamontiel deleted the gonza/test-xcm-transfer-and-pay-fees branch November 25, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited) not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants