Lazy loading improvements #3048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomarQ
added
B5-clientnoteworthy
WASM runtime size check:Compared to target branchMoonbase runtime: 2264 KB (no changes) ✅ Moonbeam runtime: 2228 KB (no changes) ✅ Moonriver runtime: 2232 KB (no changes) ✅ Compared to latest release (runtime-3300)Moonbase runtime: 2264 KB (+236 KB compared to latest release) Moonbeam runtime: 2228 KB (+232 KB compared to latest release) Moonriver runtime: 2232 KB (+240 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master rq/lazyloading-improvements +/- ##
===============================================================
+ Coverage 79.00% 79.33% +0.33%
Files 303 303
- Lines 88208 88096 -112
===============================================================
+ Hits 69685 69890 +205
- Misses 18523 18206 -317
|
RomarQ
requested review from
gonzamontiel,
TarekkMA,
ahmadkaouk and
Agusrodri
TarekkMA
approved these changes
Nov 20, 2024
TarekkMA
approved these changes
Nov 20, 2024
|
Looks good now code is more simple using polkadot-sdk Executer |
RomarQ
added
B0-silent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Removes redundant code by reusing the
LocalCallExecuterfrom polkadot-sdk