Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update spend origin #3132

Open
wants to merge 4 commits into
base: perm-runtime-3401
Choose a base branch
from
Open

update spend origin #3132

wants to merge 4 commits into from

Conversation

RomarQ
Copy link
Contributor

@RomarQ RomarQ commented Jan 16, 2025

What does it do?

Companion of #3130 applied to runtime 3400.

@RomarQ RomarQ requested a review from stiiifff January 16, 2025 09:59
@RomarQ RomarQ self-assigned this Jan 16, 2025
Copy link
Contributor

github-actions bot commented Jan 16, 2025

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2264 KB (no changes) ✅

Moonbeam runtime: 2236 KB (no changes) ✅

Moonriver runtime: 2240 KB (no changes) ✅

Compared to latest release (runtime-3400)

Moonbase runtime: 2264 KB (+236 KB compared to latest release) ⚠️

Moonbeam runtime: 2236 KB (+224 KB compared to latest release) ⚠️

Moonriver runtime: 2240 KB (+228 KB compared to latest release) ⚠️

@RomarQ RomarQ added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. not-breaking Does not need to be mentioned in breaking changes labels Jan 16, 2025
Copy link
Contributor

github-actions bot commented Jan 16, 2025

Coverage Report

@@                          Coverage Diff                          @@
##           perm-runtime-3401   rq/update-spend-origin      +/-   ##
=====================================================================
+ Coverage              74.47%                   74.58%   +0.11%     
- Files                    377                      375       -2     
- Lines                  95720                    95682      -38     
=====================================================================
+ Hits                   71283                    71359      +76     
- Misses                 24437                    24323     -114     
Files Changed Coverage
/node/cli/src/command.rs 16.86% (-0.06%) 🔽
/node/service/src/lib.rs 62.26% (-0.02%) 🔽
/node/service/src/rpc.rs 85.00% (+0.05%) 🔼
/pallets/moonbeam-lazy-migrations/src/lib.rs 80.65% (+1.30%) 🔼
/pallets/moonbeam-lazy-migrations/src/tests.rs 98.15% (+0.34%) 🔼
/pallets/parachain-staking/src/lib.rs 91.79% (-0.16%) 🔽
/pallets/parachain-staking/src/mock.rs 97.70% (-0.06%) 🔽
/pallets/parachain-staking/src/tests.rs 90.85% (-0.04%) 🔽
/pallets/parachain-staking/src/weights.rs 38.35% (-1.92%) 🔽
/precompiles/identity/src/lib.rs 90.22% (+0.02%) 🔼
/runtime/moonbase/src/lib.rs 52.85% (+2.51%) 🔼
/runtime/moonbase/src/weights/pallet_parachain_staking.rs 19.45% (-2.50%) 🔽
/runtime/moonbase/tests/common/mod.rs 97.07% (-0.03%) 🔽
/runtime/moonbase/tests/integration_test.rs 99.38% (-0.01%) 🔽
/runtime/moonbeam/src/lib.rs 47.11% (+2.70%) 🔼
/runtime/moonbeam/src/weights/pallet_assets.rs 8.88% (+0.25%) 🔼
/runtime/moonbeam/src/weights/pallet_parachain_staking.rs 19.36% (-2.49%) 🔽
/runtime/moonbeam/tests/common/mod.rs 94.74% (-0.06%) 🔽
/runtime/moonbeam/tests/integration_test.rs 99.38% (-0.01%) 🔽
/runtime/moonriver/src/lib.rs 47.34% (+2.71%) 🔼
/runtime/moonriver/src/weights/pallet_assets.rs 8.88% (+0.25%) 🔼
/runtime/moonriver/src/weights/pallet_parachain_staking.rs 19.36% (-2.49%) 🔽
/runtime/moonriver/tests/common/mod.rs 94.85% (-0.06%) 🔽
/runtime/moonriver/tests/integration_test.rs 99.36% (-0.01%) 🔽

Coverage generated Thu Jan 16 19:25:07 UTC 2025

@RomarQ RomarQ marked this pull request as ready for review January 16, 2025 13:36
@RomarQ RomarQ force-pushed the perm-runtime-3401 branch from 07b8f0d to 77c99af Compare January 16, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant