Bugs 115850{8,9} - fix reading list table cell accessibility #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes Switch Control
with accessibility We communicate that the item is read primarily by speaking it with lower pitch. So a VoiceOver user immediately learns whether item is read/unread by noting the pitch of the voice. As read/unread status is not communicated by a word at the beginning of the accessibility label and the label begins with the title of the webpage, the user will also immediately learn the beginning words of the title of webpage. I.e., the title of the webpage and read/unread status are learned simultaneously and immediately by the VoiceOver user. This allows for quick navigation through the items, as within first fractions of a second VoiceOver user can identify both read/unread status and the beginning of the title of the article. "Read"/"Unread" is still announced after the title, in case the user is using only braille display without speech, or the user has trouble recognizing pitch changes, or the user is a Switch Control user (Switch Control does not respect the UIAccessibilitySpeechAttribute* attributes - <rdar://problem/20701917>).
|
Thank you this looks good. I'm going to merge this. |
st3fan
added a commit
that referenced
this pull request
Apr 27, 2015
Bugs 115850{8,9} - fix reading list table cell accessibility
|
Thanks. |
isabelrios
pushed a commit
to isabelrios/firefox-ios
that referenced
this pull request
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are extensive comments in the commit messages (well, in the second one as in the first one nothing unusual happens).
Fix for accessibility actions can be removed as soon as CEWendel/SWTableViewCell#312 gets merged. As that might happen who knows when, have our own interim fix in the meantime.
For easy reference:
Bug 1158508
Bug 1158509
Patches donated by A11Y LTD.