Improve testing of statsd

main_test.go

@@ -467,7 +467,10 @@ func TestStatsWriteSuccess(t *testing.T) {
 	if err != nil {
 		t.Errorf("Error setting up request.")
 	}
-	ag.statsWriteSuccess(req, "test")
+	statsErr := ag.statsWriteSuccess(req, "test")
+	if statsErr != nil {
+		t.Errorf("statsWriteSuccess should not have failed: %s", statsErr)
+	}
 }
 
 func TestStatsWriteSuccessNoStats(t *testing.T) {
@@ -478,5 +481,26 @@ func TestStatsWriteSuccessNoStats(t *testing.T) {
 	if err != nil {
 		t.Errorf("Error setting up request.")
 	}
-	tmpag.statsWriteSuccess(req, "test")
+	statsErr := tmpag.statsWriteSuccess(req, "test")
+	if statsErr != nil {
+		t.Errorf("statsWriteSuccess should not have failed: %s", statsErr)
+	}
+}
+
+func TestStatsWriteSuccessFailure(t *testing.T) {
+	t.Parallel()
+	// No stats set on autographer
+	tmpag := newAutographer(1)
+	req, err := http.NewRequest("GET", "https://foo.bar", nil)
+	if err != nil {
+		t.Errorf("Error setting up request.")
+	}
+	conf.loadFromFile("autograph.yaml")
+	// Buffer will always be full - causing an error on submission
+	conf.Statsd.Buflen = -1
+	tmpag.addStats(conf)
+	statsErr := tmpag.statsWriteSuccess(req, "test")
+	if statsErr == nil {
+		t.Error("statsWriteSuccess should have failed!")
+	}
 }

stats.go

@@ -27,12 +27,13 @@ func (a *autographer) addStats(conf configuration) (err error) {
 }
 
 // Send statsd success request
-func (a *autographer) statsWriteSuccess(r *http.Request, key string) {
+func (a *autographer) statsWriteSuccess(r *http.Request, key string) (err error) {
 	if a.stats != nil {
 		starttime := getRequestStartTime(r)
 		sendStatsErr := a.stats.Timing(key, time.Since(starttime), nil, 1.0)
 		if sendStatsErr != nil {
-			log.Warnf("Error sending statsd on success %s: %s", key, sendStatsErr)
+			return fmt.Errorf("error sending statsd on success %s: %w", key, sendStatsErr)
 		}
 	}
+	return nil
 }