Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch autograph logs in Github actions integration tests #938

Merged
merged 3 commits into from
Aug 1, 2024
Merged

Fetch autograph logs in Github actions integration tests #938

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
063fc6a
Fetch autograph logs in Github actions integration tests
oskirby Aug 1, 2024
31d19db
Syntax error!
oskirby Aug 1, 2024
ae9547b
Maybe we need to specify the filepath
oskirby Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,3 +118,13 @@ jobs:
- name: Running ${{ matrix.testcase }}
shell: bash
run: docker compose -f tools/autograph-client/integration-tests.yml run ${{ matrix.testcase }}

- name: Fetching autograph logs
shell: bash
if: ${{ always() }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this cause issues if we don't reach the previous step? Maybe we don't care if this fails in weird ways if something early (eg: checking out) fails?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the container never starts, this just outputs nothing so the failure mode is a no-op in this case.

I also don't think it matters if the job fails in weird ways at this point as we are already dealing with an error. What's one more?

run: |
if echo "${{ matrix.testcase }}" | grep -q hsm; then
docker compose -f tools/autograph-client/integration-tests.yml logs app-hsm
else
docker compose -f tools/autograph-client/integration-tests.yml logs app
fi
Loading