Skip to content

Commit

Permalink
Merge pull request #204 from HarshitSohaney/hs/fix_review
Browse files Browse the repository at this point in the history
Move review request temporarily
  • Loading branch information
artines1 authored Jul 12, 2024
2 parents cef8696 + a1bd7d3 commit d0e6e39
Showing 1 changed file with 9 additions and 5 deletions.
14 changes: 9 additions & 5 deletions lists2safebrowsing.py
Original file line number Diff line number Diff line change
Expand Up @@ -689,6 +689,15 @@ def main():

publish_to_cloud(config, chunknum)

# We have to request review after all versions of the lists are done uploading
# to avoid multiple requests
# This function is only needed for remote settings uploads, the function checks the
# value of "remote_settings_upload" in the config file
#
# We have to request review before disabling remote settings upload until versioning
# is implemented
request_rs_review()

# disable remote-settings upload for versioned lists
config.set('main', 'remote_settings_upload', 'False')

Expand All @@ -700,11 +709,6 @@ def main():
else:
print('\n\n*** Unable to get branches from shavar-prod-lists repo ***')

# We have to request review after all versions of the lists are done uploading
# to avoid multiple requests
# This function is only needed for remote settings uploads, the function checks the
# value of "remote_settings_upload" in the config file
request_rs_review()

if __name__ == "__main__":
main()

0 comments on commit d0e6e39

Please sign in to comment.