Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPP-3589 - Show news item for the holiday discount promo #4144

Merged
merged 14 commits into from
Nov 22, 2023
Merged

MPP-3589 - Show news item for the holiday discount promo #4144

merged 14 commits into from
Nov 22, 2023

Conversation

lloan
Copy link
Contributor

@lloan lloan commented Nov 21, 2023

This PR fixes MPP-3589

L10N: mozilla-l10n/fx-private-relay-l10n#165

New feature description

Show news item for the holiday discount promo

Update 11/22 - Coupon string updated to HOLIDAY20

Screenshot (if applicable)

New news item:
image

In history tab:
image

Hero view (when user clicks on news item):

image

How to test

Set your local date to 11/19/23 - this is when the news item is set to show up. All news items have a lifespan of 30 days before going into the history stack.

Checklist (Definition of Done)

  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • I've added or updated relevant docs in the docs/ directory
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.
  • All UI revisions follow the coding standards, and use Protocol tokens where applicable (see /frontend/src/styles/tokens.scss).
  • Commits in this PR are minimal and have descriptive commit messages.
  • l10n changes have been submitted to the l10n repository, if any.

@lloan lloan added the Review: XS Code review time: up to 30min label Nov 21, 2023
@lloan lloan requested a review from rafeerahman November 21, 2023 13:46
@lloan lloan self-assigned this Nov 21, 2023
Copy link
Collaborator

@Vinnl Vinnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lloan lloan added this pull request to the merge queue Nov 22, 2023
Merged via the queue into main with commit 55e623a Nov 22, 2023
7 checks passed
@lloan lloan deleted the MPP-3589 branch November 22, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: XS Code review time: up to 30min
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants