MPP-3827: Move non-model code out of emails/models.py
#4799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the signature of valid_available_subdomain to be a field validator, raising an exception on failure and returning None.
DomainAddress.make_domain_address used to take a Profile argument, and now takes a User argument. This will allow other functions to take a User instead of a Profile, and avoid circular imports.
5 tasks
groovecoder
approved these changes
Jun 20, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves code around, in preparation for moving
Profile(and other models) from theemailsapp to theprivaterelayapp.emails/exceptions.py- Defines the exceptions raised in theemailsappemails/validators.py- Defines the validator functions used in theemailsapp.emails/models.pyDomainAddress.make_domain_addressused to take aProfile, and now takes aUser.This also involved moving tests around, and some test changes for the new interfaces.