Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change release engineer to base load engineer #4917

Merged
merged 3 commits into from
Jul 31, 2024
Merged

change release engineer to base load engineer #4917

merged 3 commits into from
Jul 31, 2024

Conversation

groovecoder
Copy link
Member

No description provided.

EMMLynch
EMMLynch reviewed Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@EMMLynch EMMLynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few suggested changes

docs/base-load-engineer-playbook.md Outdated Show resolved Hide resolved
docs/base-load-engineer-playbook.md Outdated Show resolved Hide resolved
@groovecoder groovecoder force-pushed the update-rel-eng-to-base-load-eng-mpp-3853 branch from 0cf56e3 to a7b0596 Compare July 31, 2024 15:28
@groovecoder groovecoder assigned jwhitlock and say-yawn and unassigned EMMLynch Jul 31, 2024
jwhitlock
jwhitlock approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@jwhitlock jwhitlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @groovecoder, looks good.

Is the base load engineer also the incident engineering lead, or do we pick the person based on the incident type?

docs/base-load-engineer-playbook.md Outdated Show resolved Hide resolved
@groovecoder @jwhitlock
Use plain link to wikipedia
99042be 
Co-authored-by: John Whitlock <[email protected]>
@groovecoder
Copy link
Member Author

Thanks @groovecoder, looks good.

Is the base load engineer also the incident engineering lead, or do we pick the person based on the incident type?

Good question. It seems that we usually create an incident out of items from one of the channels that the base load engineer monitors. So I say we treat incident engineering lead like the other tasks re: base load engineer: "you may delegate the resulting task to the most appropriate party". I'll make that explicit in the doc too.

@groovecoder
Copy link
Member Author

I updated it to say:

If any items found during the checks below are incident-level severity, you are likely to take the role of engineering lead for the incident unless you delegate to another more appropriate party.

say-yawn
say-yawn approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@say-yawn say-yawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new playbook makes sense! Thanks for updating this.

@groovecoder groovecoder added this pull request to the merge queue Jul 31, 2024
Merged via the queue into main with commit e8f15b2 Jul 31, 2024
29 checks passed
@groovecoder groovecoder deleted the update-rel-eng-to-base-load-eng-mpp-3853 branch July 31, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EMMLynch EMMLynch EMMLynch left review comments

@say-yawn say-yawn say-yawn approved these changes

@jwhitlock jwhitlock jwhitlock approved these changes

Assignees

@groovecoder groovecoder

@jwhitlock jwhitlock

@say-yawn say-yawn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@groovecoder @jwhitlock @say-yawn @EMMLynch