Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refractor some Helpers #1

Merged
merged 5 commits into from
Jan 1, 2025
Merged

Refractor some Helpers #1

merged 5 commits into from
Jan 1, 2025

Conversation

mpikzink
Copy link
Owner

@mpikzink mpikzink commented Jan 1, 2025

Simplify the helper functions by using Laravel's built-in functions. Refactor the code to reduce custom implementations and use native Laravel methods instead. This approach ensures cleaner and more maintainable code without the need for extra documentation.

Please give a short description what your pull request is for

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@mpikzink mpikzink merged commit bb7899c into master Jan 1, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant