Refresh worker environment after update #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weshinsley
approved these changes
Nov 28, 2024
| @@ -9,6 +9,7 @@ vignette: > | |||
|
|
|||
| ```{r setup, include = FALSE} | |||
| source("common.R") | |||
| options(hipercow.timeout = 120) | |||
There was a problem hiding this comment.
Probably don't need this any more, but it doesn't matter either
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After we update the
rrqenvironment we should send an environment refresh request to any active workers, otherwise people will be confused that their tasks don't use the new environment (this is noticed in the docs already in #140).This does mean that if a user creates the rrq controller, creates the rrq env and then launches workers, the workers will load the environment twice but that's fine.