Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lsp): support ddc_source_lsp server capabilities #505

Closed
wants to merge 7 commits into from

Conversation

psuong
Copy link

@psuong psuong commented Sep 17, 2024

  • Adds support for ddc_source_lsp capabilities

    • Creates an array of tuples ( mod_name, server_capability_callback) and picks the first supported capability available for autocompletion plugin with nvim-lsp

    Testing Reqs

  • Ran luarocks test with 8 successes (no new tests added)

Copy link
Contributor

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(lsp): some lsp-related bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (Steps to reproduce in PR description).
  • Updated documentation.
  • Updated CHANGELOG.md

@mrcjkb
Copy link
Owner

mrcjkb commented Sep 17, 2024

Hey 👋

thanks for the PR 🙏
I don't want to add too many plugins' client capabilities automatically, because that decreases stability (especially when it's a plugin that doesn't have SemVer releases, or one that I can't dog feed myself).

I'm actually thinking of removing the existing code that automatically adds other plugins' client capabilities and perhaps suggesting to upstream an API for registering capabilities with Neovim core, so that plugins can register themselves.

@mrcjkb mrcjkb closed this Sep 17, 2024
@psuong
Copy link
Author

psuong commented Sep 17, 2024

Alright, that makes sense, I'll keep a look out for that api in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants