feat(dap): switch to using lldb adapter, dap-client configuration from config, load launch.json by default, probe-rs support
#93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom config, load `launch.json` by default, `probe-rs` support
Andrew-Collins
commented
Dec 10, 2023
|
Wow, this looks great, thanks! 😄 I'll try to find some time to review this in detail soon. |
|
No worries. 😄 Feel free to ask for things to be moved around; I did things in a way that made sense to me, but I'm happy to defer to your opinion/vision. |
|
cc @richchurcher tagging you because you were interested in this, too 😄 |
This was
linked to
issues
Dec 11, 2023
mrcjkb
requested changes
Dec 11, 2023
Co-authored-by: Marc Jakobi <[email protected]>
skip-checks: true
Co-authored-by: Marc Jakobi <[email protected]>
Co-authored-by: Marc Jakobi <[email protected]>
mrcjkb
reviewed
Dec 12, 2023
mrcjkb
approved these changes
Dec 12, 2023
This was referenced Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Added support for the
probe-rsadapter, and in doing so implemented (at least in spirit) #29 and #66.There are a lot of possible implementations, so I'll add some comments to the diffs discussing what I came up with.
Things done
Switch to using
lldbadapter instead ofrt_lldb.Added
dap.configurationentry to config, allowing for configuration of the dap-client.launch.jsonwith the fallback of a basic config of thelldbadapter.Support
probe-rsadapter when configuring the dap-client.Tested, as applicable:
bustedspecsUpdated CHANGELOG.md (if applicable).
Fits CONTRIBUTING.md