Build arm64 binaries #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build arm64 binaries
Fix release asset name
mtsmfm
reviewed
Apr 26, 2024
| - target: x86_64-pc-windows-gnu | ||
| os: ubuntu-latest | ||
| extension: .exe | ||
| - target: x86_64-apple-darwin | ||
| # - target: x86_64-apple-darwin | ||
| # os: ubuntu-latest |
There was a problem hiding this comment.
I thought this os should be macos-latest though, it seems you've tried both
https://github.com/int128/split-test/actions/runs/8845858159/job/24290599577
mtsmfm
reviewed
Apr 26, 2024
| uses: actions/create-release@v1 | ||
| - uses: actions/checkout@v4 | ||
| - run: rustup update stable | ||
| - run: rustup default stable |
There was a problem hiding this comment.
According to the error message
https://github.com/int128/split-test/actions/runs/8845858159/job/24290599577
error[E0463]: can't find crate for `core`
|
= note: the `x86_64-apple-darwin` target may not be installed
= help: consider downloading the target with `rustup target add x86_64-apple-darwin`
perhaps this patch helps?
Suggested change
| - run: rustup default stable | |
| - run: rustup default stable | |
| - run: rustup target add ${{ matrix.target }} |
There was a problem hiding this comment.
@int128 Do you still have interests on this? At least I'd like to fix the CI if it has any trouble
There was a problem hiding this comment.
Sorry, I forgot everything about this pull request. If needed, feel free to pick my changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'd like to run split-test on the self-hosted runners of Linux arm64. This pull request will release both amd64 and arm64 binaries.
In these workflows, some actions are already archived.
actions-rs/*actions are archived. I replaced them with rustup and cargo.actions/upload-release-assetaction is archived. I replaced it with gh command.Also I could not build a binary for x86_64-apple-darwin due to some errors, so commented it out.
Thanks.