Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Button] Apply correct line height to Button text #44907

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

kanavbajaj
Copy link

@kanavbajaj kanavbajaj commented Dec 31, 2024

closes #38675

@mui-bot
Copy link

mui-bot commented Dec 31, 2024

Netlify deploy preview

https://deploy-preview-44907--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against aeff701

@samuelsycamore samuelsycamore changed the title Fixes #38675. Fix [Button] Text wrap issue. [Button] Apply correct line height to Button text Dec 31, 2024
@samuelsycamore samuelsycamore added the component: button This is the name of the generic UI component, not the React module! label Dec 31, 2024
@zannager zannager requested a review from DiegoAndai January 1, 2025 04:17
@DiegoAndai
Copy link
Member

Hey @kanavbajaj! Thanks for working on this 😊. May I ask you to update/fix the failing tests? You might find our contributing guide useful for this.

Assigning @zanivan for review. Victor, may I ask you to check the broken Argos tests?

@DiegoAndai DiegoAndai requested review from zanivan and removed request for DiegoAndai January 9, 2025 15:43
@DiegoAndai DiegoAndai added design: material This is about Material Design, please involve a visual or UX designer in the process design This is about UI or UX design, please involve a designer labels Jan 9, 2025
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 9, 2025
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 9, 2025
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: button This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process design This is about UI or UX design, please involve a designer PR: out-of-date The pull request has merge conflicts and can't be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Button] Text wrap issue
4 participants