Add Firewall support #115
Merged
Add Firewall support #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
approved these changes
Apr 5, 2021
|
Awesome work @janus-reith 🚀 |
Closed
github-actions bot
pushed a commit
to markusheinemann/ui-driver-hetzner
that referenced
this pull request
Jun 1, 2022
# 1.0.0 (2022-06-01) ### Bug Fixes * adjusted due new Rancher version ([f51fff4](f51fff4)) * hetznerConfig networks=NotNullable (fix: [mxschmitt#48](https://github.com/markusheinemann/ui-driver-hetzner/issues/48)) ([mxschmitt#49](https://github.com/markusheinemann/ui-driver-hetzner/issues/49)) ([1ff0c49](1ff0c49)) * remove the serverLabels config if we don't set any labels ([mxschmitt#111](https://github.com/markusheinemann/ui-driver-hetzner/issues/111)) ([55886d7](55886d7)) * typo ([6a9f7c8](6a9f7c8)) ### Features * add firewall support ([mxschmitt#115](https://github.com/markusheinemann/ui-driver-hetzner/issues/115)) ([4ce4c87](4ce4c87)) * also add labels to Hetzner Server from NodeTemplate ([mxschmitt#109](https://github.com/markusheinemann/ui-driver-hetzner/issues/109)) ([988200f](988200f)) * bump docker-machine-driver to 2.0.0 ([deb05e6](deb05e6)) * implement possibility to add additional ssh keys ([mxschmitt#108](https://github.com/markusheinemann/ui-driver-hetzner/issues/108)) ([8697b94](8697b94)) * Networks Feature (fix: [mxschmitt#37](https://github.com/markusheinemann/ui-driver-hetzner/issues/37)) ([mxschmitt#38](https://github.com/markusheinemann/ui-driver-hetzner/issues/38)) ([1e5e569](1e5e569)) * private network support ([mxschmitt#83](https://github.com/markusheinemann/ui-driver-hetzner/issues/83)) ([424f834](424f834))
github-actions bot
pushed a commit
to markusheinemann/ui-driver-hetzner
that referenced
this pull request
Jun 1, 2022
# 1.0.0 (2022-06-01) ### Bug Fixes * adjusted due new Rancher version ([f51fff4](f51fff4)) * hetznerConfig networks=NotNullable (fix: [mxschmitt#48](https://github.com/markusheinemann/ui-driver-hetzner/issues/48)) ([mxschmitt#49](https://github.com/markusheinemann/ui-driver-hetzner/issues/49)) ([1ff0c49](1ff0c49)) * remove the serverLabels config if we don't set any labels ([mxschmitt#111](https://github.com/markusheinemann/ui-driver-hetzner/issues/111)) ([55886d7](55886d7)) * typo ([6a9f7c8](6a9f7c8)) ### Features * add firewall support ([mxschmitt#115](https://github.com/markusheinemann/ui-driver-hetzner/issues/115)) ([4ce4c87](4ce4c87)) * also add labels to Hetzner Server from NodeTemplate ([mxschmitt#109](https://github.com/markusheinemann/ui-driver-hetzner/issues/109)) ([988200f](988200f)) * bump docker-machine-driver to 2.0.0 ([deb05e6](deb05e6)) * implement possibility to add additional ssh keys ([mxschmitt#108](https://github.com/markusheinemann/ui-driver-hetzner/issues/108)) ([8697b94](8697b94)) * Networks Feature (fix: [mxschmitt#37](https://github.com/markusheinemann/ui-driver-hetzner/issues/37)) ([mxschmitt#38](https://github.com/markusheinemann/ui-driver-hetzner/issues/38)) ([1e5e569](1e5e569)) * private network support ([mxschmitt#83](https://github.com/markusheinemann/ui-driver-hetzner/issues/83)) ([424f834](424f834))
github-actions bot
pushed a commit
to markusheinemann/ui-driver-hetzner
that referenced
this pull request
Jun 1, 2022
# 1.0.0 (2022-06-01) ### Bug Fixes * adjusted due new Rancher version ([f51fff4](f51fff4)) * hetznerConfig networks=NotNullable (fix: [mxschmitt#48](https://github.com/markusheinemann/ui-driver-hetzner/issues/48)) ([mxschmitt#49](https://github.com/markusheinemann/ui-driver-hetzner/issues/49)) ([1ff0c49](1ff0c49)) * remove the serverLabels config if we don't set any labels ([mxschmitt#111](https://github.com/markusheinemann/ui-driver-hetzner/issues/111)) ([55886d7](55886d7)) * typo ([6a9f7c8](6a9f7c8)) ### Features * add firewall support ([mxschmitt#115](https://github.com/markusheinemann/ui-driver-hetzner/issues/115)) ([4ce4c87](4ce4c87)) * also add labels to Hetzner Server from NodeTemplate ([mxschmitt#109](https://github.com/markusheinemann/ui-driver-hetzner/issues/109)) ([988200f](988200f)) * bump docker-machine-driver to 2.0.0 ([deb05e6](deb05e6)) * implement possibility to add additional ssh keys ([mxschmitt#108](https://github.com/markusheinemann/ui-driver-hetzner/issues/108)) ([8697b94](8697b94)) * Networks Feature (fix: [mxschmitt#37](https://github.com/markusheinemann/ui-driver-hetzner/issues/37)) ([mxschmitt#38](https://github.com/markusheinemann/ui-driver-hetzner/issues/38)) ([1e5e569](1e5e569)) * private network support ([mxschmitt#83](https://github.com/markusheinemann/ui-driver-hetzner/issues/83)) ([424f834](424f834))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #114
I tried to stick as close to the existing structure as possible.
Currently it only displays the list of firewalls to choose from by name, I'm happy for suggestions on how to maybe display the included in- and outbound rules aswell, since they are queryable by the api, but so far I haven't had a clean way in mind to do that.
As for the disclaimer on the label, I just copied it from the Networks label since it seems to apply here as well (BTW Networks doesn't seem to be in beta anymore).
Tested it and it works fine for me, firewalls are listed, and selected firewalls are applied to created machines.