[#8543] Update Attachment masking job setup #8544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change increase the `Regexp.timeout` from 1 sec to 60 secs. This is needed since Rails 8.0 now defaults to 1 sec to stop possible DoS attacks. Since this is in a background job the timeout duration is less of a concern. See: rails/rails#53490 Fixes #8543
gbp
force-pushed
the
8543-increase-regexp-timeout
branch
from
611fec0 to
c12dc6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Fixes #8543
See: rails/rails#53490
What does this do?
Update Attachment masking job setup
Why was this needed?
This change increase the
Regexp.timeoutfrom 1 sec to 60 secs.This is needed since Rails 8.0 now defaults to 1 sec to stop possible DoS attacks. Since this is in a background job the timeout duration is less of a concern.