Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[South Africa] Add cron job to sync EP UUIDs #2342

Merged
merged 1 commit into from
Feb 19, 2018

Conversation

chrismytton
Copy link
Member

@chrismytton chrismytton commented Jan 31, 2018

Extracted from #2331

This adds a cron job that runs the core_sync_everypolitician_uuid management command that was added in #2331 once a day on staging and production.

Notes to merger

@coveralls
Copy link

coveralls commented Jan 31, 2018

Coverage Status

Coverage remained the same at 54.278% when pulling 9368136 on sync-everypolitician-uuid-cron-job into 54ca000 on master.

@chrismytton chrismytton requested a review from mhl February 19, 2018 10:34
Copy link
Contributor

@mhl mhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be out-of-date with respect to master now - I've left a comment inline about that

@@ -77,5 +80,8 @@ MAILTO=cron-!!(*= $site *)[email protected]
13 2 * * * !!(*= $user *)!! run_management_command core_export_to_popolo_json /data/vhost/!!(*= $vhost *)!!/media_root/popolo_json/ http://www.pa.org.za
30 3 * * * !!(*= $user *)!! run_management_command core_export_to_popolo_json --pombola /data/vhost/!!(*= $vhost *)!!/media_root/popolo_json/ http://www.pa.org.za

# Sync EveryPolitician UUIDs to local DB
30 10 * * * !!(*= $user *)!! output-on-error run_management_command core_sync_everypolitician_uuid
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the management command has a different name now - shouldn't it be: south_africa_sync_everypolitician_uuid?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, of course! Good catch! 😟

@mysociety-pusher mysociety-pusher force-pushed the sync-everypolitician-uuid-cron-job branch from fa34824 to 9368136 Compare February 19, 2018 15:12
@mysociety-pusher mysociety-pusher merged commit 9368136 into master Feb 19, 2018
@chrismytton chrismytton deleted the sync-everypolitician-uuid-cron-job branch June 10, 2019 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants