Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Person.everypolitician_uuid method #2343

Merged
merged 1 commit into from
Feb 2, 2018

Conversation

chrismytton
Copy link
Member

@chrismytton chrismytton commented Feb 1, 2018

Adds a method that returns the EveryPolitician UUID from the persons identifiers if there's one present.

This is needed for the WriteInPublic integration we're doing for South Africa. We're going to need to use the EP UUID quite a bit for that, so I think it makes sense to add a shortcut for accessing that information.

This was extracted from #2329 and follows on from #2331.

This returns the EveryPolitician UUID from the persons identifiers if
there's one present.
@mysociety-pusher mysociety-pusher force-pushed the add-person-everypolitician_uuid-method branch from efe3fe6 to edbb136 Compare February 1, 2018 18:20
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 54.18% when pulling edbb136 on add-person-everypolitician_uuid-method into 744fffd on master.

@chrismytton chrismytton requested a review from mhl February 2, 2018 09:31
Copy link
Contributor

@mhl mhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@mysociety-pusher mysociety-pusher merged commit edbb136 into master Feb 2, 2018
@mysociety-pusher mysociety-pusher deleted the add-person-everypolitician_uuid-method branch June 7, 2019 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants