Add WriteInPublic API client #2344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhl
suggested changes
Feb 6, 2018
pombola/writeinpublic/client.py
Outdated
| try: | ||
| return requests.post(url, json=payload, params=params) | ||
| except requests.exceptions.RequestException as err: | ||
| raise self.WriteInPublicException(err) |
There was a problem hiding this comment.
The argument to this exceptions constructor is expected to be a string, I think, so perhaps this should be:
raise self.WriteInPublicException(unicode(err))
| 'api_key': self.api_key, | ||
| 'person__popolo_uri': person_popolo_uri, | ||
| } | ||
| response = requests.get(url, params=params) |
There was a problem hiding this comment.
I think that all calls to requests.get or requests.post should be followed by response.raise_for_status() afterwards, or you won't get an exception for 4xx and 5xx responses, and will get a less helpful error later...
There was a problem hiding this comment.
Ah good shout, I didn't know about that method, added that in de1f549.
|
@mhl I've made those changes now, so I think this is ready for another review. |
mhl
approved these changes
Feb 7, 2018
This is a very simple wrapper around the WriteInPublic API. Currently it only implements the features that we need for integrating it into Pombola. I've added some tests for the basic functionality, but in the interests of time I've skipped writing tests for the .people() and .answers() methods, so will need to revisit that at some point in the future.
mysociety-pusher
force-pushed
the
writeinpublic-api-client
branch
from
de1f549 to
6fdab17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very simple wrapper around the WriteInPublic API. Currently it only implements the features that we need for integrating it into Pombola.
I've added some tests for the basic functionality, but in the interests of time I've skipped writing tests for the
.people()and.answers()methods, so will need to revisit that at some point in the future.Extracted from #2329
Part of #1682