Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore logger.Start() setup due to missing values #10

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

jonathanio
Copy link
Contributor

Restore the logger.Start() setup as the map was not populating and the application build-time information was not being provided correctly.

Checklist

Before raising or requesting a review of the pull request, please check and confirm the following items have been performed, where possible:

  • I have performed a self-review of my code and run any tests locally to check
  • I have added tests that prove that any changes are effective and work correctly
  • I have made corresponding changes, as needed, to the repository documentation
  • Each commit in, and this pull request, have meaningful subjects and bodies for context
  • I have added release/..., type/..., and changes/... labels, as needed, to this pull request

Restore the logger.Start() setup as the map was not populating and the
application build-time information was not being provided correctly.
@jonathanio jonathanio added priority/normal This is a normal-priority issue or pull request release/fix A fix for a bug or identified issue with this pull request update/go Update with changes to Go files or applications labels Aug 14, 2024
@jonathanio jonathanio self-assigned this Aug 14, 2024
@jonathanio jonathanio enabled auto-merge August 14, 2024 16:10
@jonathanio jonathanio merged commit 2ec042b into main Aug 14, 2024
9 checks passed
@jonathanio jonathanio deleted the fix-logger-setup branch August 14, 2024 16:12
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 10.04%. Comparing base (a5b1287) to head (6d2371f).
Report is 2 commits behind head on main.

Files Patch % Lines
internal/cmd/serve.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
- Coverage   10.16%   10.04%   -0.13%     
==========================================
  Files          17       17              
  Lines         492      498       +6     
==========================================
  Hits           50       50              
- Misses        442      448       +6     
Flag Coverage Δ
unit-tests 10.04% <0.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/cmd/serve.go 0.00% <0.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/normal This is a normal-priority issue or pull request release/fix A fix for a bug or identified issue with this pull request update/go Update with changes to Go files or applications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant