Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dashboard to use the Pod IP as listening address #21

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

jonathanio
Copy link
Contributor

@jonathanio jonathanio commented Aug 23, 2024

Update the dashboard application to use the Pod IP as the listening address, which should help improve the data in the log files by allowing that address to be used instead of the generic 0.0.0.0.

This is being done through the environment variable setting overrides using viper as it's easier than setting it via the command-line.

Checklist

Before raising or requesting a review of the pull request, please check and confirm the following items have been performed, where possible:

  • I have performed a self-review of my code and run any tests locally to check
  • I have added tests that prove that any changes are effective and work correctly
  • I have made corresponding changes, as needed, to the repository documentation
  • Each commit in, and this pull request, have meaningful subjects and bodies for context
  • I have added release/..., type/..., and changes/... labels, as needed, to this pull request

Update the dashboard application to use the Pod IP as the listening
address, which should help improve the data in the log files by allowing
that address to be used instead of the generic 0.0.0.0.

This is being done through the environment variable setting overrides
using viper as it's easier than setting it via the command-line.
@jonathanio jonathanio added priority/normal This is a normal-priority issue or pull request release/update An update to an existing feature is made with this pull request update/helm Update with changes to the Helm charts labels Aug 23, 2024
@jonathanio jonathanio self-assigned this Aug 23, 2024
@jonathanio jonathanio enabled auto-merge August 23, 2024 08:45
@jonathanio jonathanio merged commit 11843c3 into main Aug 23, 2024
12 checks passed
@jonathanio jonathanio deleted the update-pod-address-handling branch August 23, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/normal This is a normal-priority issue or pull request release/update An update to an existing feature is made with this pull request update/helm Update with changes to the Helm charts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant