Reduce likelyhood of race in node.fork_publish #4804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 5, 2024 21:23
Some testcases (e.g. node.fork_publish) are racy because too many things can happen between 2 polls. While this doesn't fix the racy testcase, it greatly reduces the likelyhood that testcases are failing due to timing issues
…on before fork detection
Test Results for Commit 1e08592Pull Request 4804: Results Test Case Results
Last updated: 2024-12-05 23:29:49 UTC |
pwojcikdev
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This testcase fails a lot on windows github runners and in ~3% locally.
Reorder block processing in direct succession to increase likelihood of fork handling before election confirmation. (With this change alone the testcase fails in ~0.2%)
Reduce default poll interval from 50ms to 10ms to reduce internal node operations between 2 polls. (With this change alone the testcase fails in ~0.2%)
Both changes are needed - Reordering alone or poll interval changes alone were insufficient. With both changes applied, test passes reliably (10000/10000).