Fix activate immediately logic #4822
Merged
+186
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results for Commit 725f3cbPull Request 4822: Results Test Case Results
Last updated: 2025-01-09 20:29:33 UTC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main intention of this PR is to fix the bug in activate immediately logic; the if statement needs to be inverted. However, fixing it made
TEST (node, bootstrap_fork_open)testcase fail, which upon further investigation uncovered bugs in bootstrap service and request aggregator.To debug the problems I added quite a bit of new debug logging points which I decided to keep. It might be worthwhile to profile the node to ensure none of the log statements are impacting hot path too much.