Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ecse 1412 - just re-arrainging the schema, broke some CMR tests that were fixed. #1980

Merged
merged 7 commits into from
Oct 19, 2023

Conversation

eereiter
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2023

Codecov Report

Merging #1980 (854611e) into master (e1219ab) will decrease coverage by 0.02%.
Report is 4 commits behind head on master.
The diff coverage is 92.30%.

@@            Coverage Diff             @@
##           master    #1980      +/-   ##
==========================================
- Coverage   55.21%   55.20%   -0.02%     
==========================================
  Files         990      990              
  Lines       62909    62927      +18     
  Branches     1547     1551       +4     
==========================================
+ Hits        34736    34739       +3     
- Misses      26628    26637       +9     
- Partials     1545     1551       +6     
Files Coverage Δ
...cmr/umm_spec/test/iso19115_expected_conversion.clj 97.69% <100.00%> (+1.06%) ⬆️
...-spec-lib/src/cmr/umm_spec/test/umm_generators.clj 86.31% <100.00%> (ø)
...mm_spec/umm_to_xml_mappings/iso19115_2/spatial.clj 99.43% <100.00%> (-0.01%) ⬇️
...mm_mappings/iso_shared/shared_iso_parsing_util.clj 100.00% <100.00%> (ø)
...cmr/umm_spec/xml_to_umm_mappings/dif10/spatial.clj 96.92% <91.42%> (-2.28%) ⬇️
...mr/umm_spec/xml_to_umm_mappings/echo10/spatial.clj 95.87% <85.71%> (-4.13%) ⬇️
...mm_spec/xml_to_umm_mappings/iso19115_2/spatial.clj 95.84% <89.65%> (-1.04%) ⬇️

... and 3 files with indirect coverage changes

@jmaeng72
Copy link
Contributor

I think we are trying to keep the code coverage the same or more than the current percentage. Can you add unit tests to increase your code coverage?

@eereiter
Copy link
Contributor Author

All I did was fix tests, If I were to add a unit test, it would be for something unrelated.

Copy link
Contributor

@jceaser jceaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functionally this looks great, just suggest some minor changes to variable names if it is acceptable to the author.

@eereiter eereiter merged commit a53cf62 into master Oct 19, 2023
1 check passed
@eereiter eereiter deleted the ECSE-1412 branch October 25, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants