-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ecse 1412 - just re-arrainging the schema, broke some CMR tests that were fixed. #1980
Conversation
…to use oneOf instead of anyOf, but keeping the CMR record in/outputs the same.
…eInformationType to see if CMR can handle it.
…formationType, but keeping titles for each sub-schema.
Codecov Report
@@ Coverage Diff @@
## master #1980 +/- ##
==========================================
- Coverage 55.21% 55.20% -0.02%
==========================================
Files 990 990
Lines 62909 62927 +18
Branches 1547 1551 +4
==========================================
+ Hits 34736 34739 +3
- Misses 26628 26637 +9
- Partials 1545 1551 +6
|
I think we are trying to keep the code coverage the same or more than the current percentage. Can you add unit tests to increase your code coverage? |
All I did was fix tests, If I were to add a unit test, it would be for something unrelated. |
umm-spec-lib/src/cmr/umm_spec/xml_to_umm_mappings/dif10/spatial.clj
Outdated
Show resolved
Hide resolved
umm-spec-lib/src/cmr/umm_spec/xml_to_umm_mappings/echo10/spatial.clj
Outdated
Show resolved
Hide resolved
umm-spec-lib/src/cmr/umm_spec/xml_to_umm_mappings/iso_shared/shared_iso_parsing_util.clj
Show resolved
Hide resolved
umm-spec-lib/src/cmr/umm_spec/xml_to_umm_mappings/iso19115_2/spatial.clj
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
functionally this looks great, just suggest some minor changes to variable names if it is acceptable to the author.
No description provided.