Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMR-9497 Moving KMS cache straight to redis #1984

Merged
merged 3 commits into from
Oct 24, 2023
Merged

CMR-9497 Moving KMS cache straight to redis #1984

merged 3 commits into from
Oct 24, 2023

Conversation

eereiter
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2023

Codecov Report

Merging #1984 (3dc4f2e) into master (a53cf62) will decrease coverage by 0.01%.
Report is 7 commits behind head on master.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1984      +/-   ##
==========================================
- Coverage   55.25%   55.25%   -0.01%     
==========================================
  Files         990      990              
  Lines       63001    62995       -6     
  Branches     1547     1548       +1     
==========================================
- Hits        34813    34809       -4     
+ Misses      26641    26640       -1     
+ Partials     1547     1546       -1     
Files Coverage Δ
...app-lib/src/cmr/common_app/services/kms_lookup.clj 80.99% <ø> (-0.31%) ⬇️
indexer-app/src/cmr/indexer/system.clj 26.41% <ø> (+0.48%) ⬆️
search-app/src/cmr/search/system.clj 18.51% <ø> (ø)
dev-system/src/cmr/dev_system/system.clj 27.14% <0.00%> (ø)
bootstrap-app/src/cmr/bootstrap/system.clj 17.24% <0.00%> (-0.31%) ⬇️
transmit-lib/src/cmr/transmit/kms.clj 69.60% <0.00%> (-0.81%) ⬇️
...pp-lib/src/cmr/common_app/services/kms_fetcher.clj 52.17% <0.00%> (+2.17%) ⬆️

Copy link
Contributor

@jceaser jceaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we actually talked a lot about this code, it looks good.

[job-key]
{:job-type RefreshKmsCacheJob
:job-key job-key
:interval 7200})
:daily-at-hour-and-minute [02 00]})
Copy link
Contributor

@jceaser jceaser Oct 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we may need a wiki page to track the schedules for all our jobs to make sure we spread them out, just thinking out loud ... or a markdown page in the code

@eereiter eereiter merged commit ae51f1f into master Oct 24, 2023
1 check passed
@eereiter eereiter deleted the CMR-9497-1 branch December 12, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants