EDSC-4280 fixes issues with view all facet util functions

[daniel-zamora]

Overview

What is the feature?

Fixes issue where empty string titles in cmr metadata causes edsc to throw errors when trying to call toUpperCase.

What is the Solution?

Added util function to safely do this, refactored relevant to use new util.

What areas of the application does this impact?

getStartingLetters and buildOrganizedFacets in facets.js util
Added tests for these two functions and new util function getNormalizedFirstLetter

Testing

A little tricky to test, in environment as it needs bad facet metadata. However locally you can add on line 89 in viewAllFacets.js reducer to replicate the problem,

      payload.facets = payload.facets.map((facetCategory) => {
        if (facetCategory.title === 'Projects') {
          return {
            ...facetCategory,
            children: [...facetCategory.children, { title: '' }]
          }
        }

        return facetCategory
      })

Checklist

• I have added automated tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.77%. Comparing base (3f1a79a) to head (5822899).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1845      +/-   ##
==========================================
- Coverage   93.78%   93.77%   -0.01%     
==========================================
  Files         778      778              
  Lines       18885    18888       +3     
  Branches     4868     4850      -18     
==========================================
+ Hits        17711    17712       +1     
+ Misses       1099     1097       -2     
- Partials       75       79       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.