Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up UT ipml. Fixes: #2515 #234

Open
wants to merge 3 commits into
base: devel
Choose a base branch
from

Conversation

AlesKus
Copy link

@AlesKus AlesKus commented Dec 17, 2024

Related Issue(s) nasa/fprime#2515
Has Unit Tests (y/n) n
Documentation Included (y/n) n

Change Description

Move the generated UT template files into "test/ut" folder. The ".template" suffix is added to generated cpp/hpp file names.

Rationale

Fixes nasa/fprime#2515.

Testing/Review Recommendations

Create a component and check behavior of "fprime-util impl --ut" with:

  • missing "test/ut" folder;
  • existing "test/ut", but empty;
  • existing "test/ut" with UT real cpp/hpp files;
  • existing "test/ut" with UT real cpp/hpp files and templates.

Future Work

If/When this PR is merged and released, the tutorials should be updated.

Unverified

This user has not yet uploaded their public signing key.
@LeStarch LeStarch requested a review from thomas-bc December 18, 2024 01:59
@LeStarch
Copy link
Collaborator

I looked through this, but I hope @thomas-bc will too.

@AlesKus
Copy link
Author

AlesKus commented Dec 18, 2024

For some reason the checks fail at cloning:

At the moment, I don't know what is the issue and how it is related to my change.

@LeStarch
Copy link
Collaborator

It isn't. Github hosting issue of some form. The fix is to rerun the failing jobs.

Copy link
Contributor

@thomas-bc thomas-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!
I can't test this right now cause GitHub is having issues, but I will as soon as service is back to normal and approve then.

@AlesKus would you want to make the PRs to update the tutorials?
If not we can take care of it, but I'd like to have the tutorial PRs ready before merging this.

@AlesKus
Copy link
Author

AlesKus commented Jan 14, 2025

Sure, I'll create PRs for tutorials soon.

@AlesKus
Copy link
Author

AlesKus commented Jan 15, 2025

This comment is used to track the tutorial updates. The updates are based on nasa/fprime#2997 and nasa/fprime#2515.

Tutorial PR
fprime-workshop-led-blinker fprime-community/fprime-workshop-led-blinker#102
fprime-tutorial-math-component TODO
fprime-system-reference TODO

@AlesKus
Copy link
Author

AlesKus commented Jan 15, 2025

I went through the LED tutorial and updated the instructions.
Two observations:

  • the test .cpp files should be commented in the cmake file before generating the ut build cache since they are absent;
  • for some reason, the LedTesterHelpers.template.cpp is generated by the 'impl --ut' and copied into 'test/ut'; I don't know whether it is an expected behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fprime-utils: Clean-Up UT Impl
3 participants