-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up UT ipml. Fixes: #2515 #234
base: devel
Are you sure you want to change the base?
Conversation
I looked through this, but I hope @thomas-bc will too. |
For some reason the checks fail at cloning:
At the moment, I don't know what is the issue and how it is related to my change. |
It isn't. Github hosting issue of some form. The fix is to rerun the failing jobs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
I can't test this right now cause GitHub is having issues, but I will as soon as service is back to normal and approve then.
@AlesKus would you want to make the PRs to update the tutorials?
If not we can take care of it, but I'd like to have the tutorial PRs ready before merging this.
Sure, I'll create PRs for tutorials soon. |
This comment is used to track the tutorial updates. The updates are based on nasa/fprime#2997 and nasa/fprime#2515.
|
I went through the LED tutorial and updated the instructions.
|
Change Description
Move the generated UT template files into "test/ut" folder. The ".template" suffix is added to generated cpp/hpp file names.
Rationale
Fixes nasa/fprime#2515.
Testing/Review Recommendations
Create a component and check behavior of "fprime-util impl --ut" with:
Future Work
If/When this PR is merged and released, the tutorials should be updated.