get arrivals by airport

Signed-off-by: Navid Yaghoobi <[email protected]>
navidys · Nov 8, 2023 · 3810630 · 3810630
1 parent 237046b
commit 3810630
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 13 deletions.
diff --git a/cmd/gopensky/arrivals.go b/cmd/gopensky/arrivals.go
@@ -27,7 +27,7 @@ func runArrivals(cmd *cobra.Command, args []string) {
 		return
 	}
 
-	flights, err := gopensky.GetArrivalsByAirport(conn, "ymml", cmdBeginTime, cmdEndTime)
+	flights, err := gopensky.GetArrivalsByAirport(conn, cmdAirport, cmdBeginTime, cmdEndTime)
 	if err != nil {
 		log.Error().Msgf("%v", err)
 

diff --git a/connection.go b/connection.go
@@ -155,9 +155,7 @@ func (h apiResponse) processWithError(unmarshalInto interface{}) error {
 
 func handleError(statusCode int, data []byte) error {
 	errorModel := httpModelError{
-		// Because:      http.StatusText(statusCode),
-		Message:      string(data),
-		ResponseCode: statusCode,
+		Message: fmt.Sprintf("%s %s", http.StatusText(statusCode), data),
 	}
 
 	return errorModel

diff --git a/errors.go b/errors.go
@@ -44,18 +44,9 @@ func (c connectionError) Unwrap() error {
 }
 
 type httpModelError struct {
-	// human error message, formatted for a human to read
-	// example: human error message
 	Message string `json:"message"`
-	// HTTP response code
-	// min: 400
-	ResponseCode int `json:"response"`
 }
 
 func (e httpModelError) Error() string {
 	return e.Message
 }
-
-func (e httpModelError) Code() int {
-	return e.ResponseCode
-}
diff --git a/states.go b/states.go
@@ -19,6 +19,10 @@ func GetStates(ctx context.Context, time int64, icao24 []string,
 		return nil, fmt.Errorf("client: %w", err)
 	}
 
+	if time < 0 {
+		return nil, ErrInvalidUnixTime
+	}
+
 	requestParams := getStateRequestParams(time, icao24, bBox, extended)
 
 	response, err := conn.doGetRequest(ctx, nil, "/states/all", requestParams)