Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introside: 📝 update confirmation text #3300

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Introside: 📝 update confirmation text #3300

merged 2 commits into from
Oct 30, 2024

Conversation

JulianNymark
Copy link
Contributor

@JulianNymark JulianNymark commented Oct 30, 2024

Description

closes #3298

Component Checklist 📝

  • JSDoc
  • Examples
  • Documentation / Decision Records
  • Storybook
  • Style mappings (@navikt/core/css/config/_mappings.js)
  • Component tokens (@navikt/core/css/tokens.json)
  • CSS class deprecations (@navikt/aksel-stylelint/src/deprecations.ts)
  • Exports (@navikt/core/react/src/index.ts and @navikt/core/react/package.json)
  • New component? CSS import (@navikt/core/css/index.css)
  • Breaking change? Update migration guide. Consider codemod.
  • Changeset (Format: <Component>: <gitmoji?> <Text>. E.g. "Button: ✨ Add feature xyz.")

Copy link

changeset-bot bot commented Oct 30, 2024

⚠️ No Changeset found

Latest commit: 341196f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JulianNymark
Copy link
Contributor Author

Need to update the changelog for affected templates as well (this data is in sanity iirc?)

Copy link
Contributor

github-actions bot commented Oct 30, 2024

Storybook demo

Endringer til review: 9

dd6d6470f | 91 komponenter | 144 stories

@KenAJoh
Copy link
Collaborator

KenAJoh commented Oct 30, 2024

Need to update the changelog for affected templates as well (this data is in sanity iirc?)

It's defined in the meta.json-file located with the templates https://github.com/navikt/aksel/blob/main/aksel.nav.no/website/pages/templates/soknad-introside/meta.json

Copy link
Contributor

@HalvorHaugan HalvorHaugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to update the changelog in meta.json as well.

Copy link
Contributor

@HalvorHaugan HalvorHaugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JulianNymark JulianNymark merged commit 561dd2e into main Oct 30, 2024
5 checks passed
@JulianNymark JulianNymark deleted the template-text branch October 30, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Rette tekst på introside-mal
3 participants