Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sanity] Config cleanup #3312

Merged
merged 3 commits into from
Nov 6, 2024
Merged

[Sanity] Config cleanup #3312

merged 3 commits into from
Nov 6, 2024

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented Oct 31, 2024

Description

Simplified config, added typings and removed "counter" input

For those instances where we are using the counter input, the hard limit is mostly arbitrary. So changed it to just give a warning if you write a title that is "to long". This avoids having to be a wordsmith just to formulate the title in as few characters as possible, rather than writing a good title

Component Checklist 📝

  • JSDoc
  • Examples
  • Documentation / Decision Records
  • Storybook
  • Style mappings (@navikt/core/css/config/_mappings.js)
  • Component tokens (@navikt/core/css/tokens.json)
  • CSS class deprecations (@navikt/aksel-stylelint/src/deprecations.ts)
  • Exports (@navikt/core/react/src/index.ts and @navikt/core/react/package.json)
  • New component? CSS import (@navikt/core/css/index.css)
  • Breaking change? Update migration guide. Consider codemod.
  • Changeset (Format: <Component>: <gitmoji?> <Text>. E.g. "Button: ✨ Add feature xyz.")

Copy link

changeset-bot bot commented Oct 31, 2024

⚠️ No Changeset found

Latest commit: 0959121

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

HalvorHaugan
HalvorHaugan previously approved these changes Nov 6, 2024
@KenAJoh KenAJoh merged commit 2d669a7 into main Nov 6, 2024
2 checks passed
@KenAJoh KenAJoh deleted the sanity-studio-update branch November 6, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants