Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Datepicker] DateWrapper now uses state instead of ref #3333

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented Nov 6, 2024

Description

This solves an issue where use of open={true} on initial render could cause the Popover-anchor to be null, thus not opening the popover.

Component Checklist 📝

  • JSDoc
  • Examples
  • Documentation / Decision Records
  • Storybook
  • Style mappings (@navikt/core/css/config/_mappings.js)
  • Component tokens (@navikt/core/css/tokens.json)
  • CSS class deprecations (@navikt/aksel-stylelint/src/deprecations.ts)
  • Exports (@navikt/core/react/src/index.ts and @navikt/core/react/package.json)
  • New component? CSS import (@navikt/core/css/index.css)
  • Breaking change? Update migration guide. Consider codemod.
  • Changeset (Format: <Component>: <gitmoji?> <Text>. E.g. "Button: ✨ Add feature xyz.")

@KenAJoh KenAJoh requested review from a team as code owners November 6, 2024 17:50
Copy link

changeset-bot bot commented Nov 6, 2024

🦋 Changeset detected

Latest commit: bd6d448

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-react Patch
@navikt/ds-css Patch
@navikt/ds-tokens Patch
@navikt/ds-tailwind Patch
@navikt/aksel-icons Patch
@navikt/aksel Patch
@navikt/aksel-stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 6, 2024

Storybook demo

16f1756ea | 91 komponenter | 144 stories

@KenAJoh KenAJoh enabled auto-merge (squash) November 7, 2024 09:56
@KenAJoh KenAJoh merged commit 702aecf into main Nov 8, 2024
4 checks passed
@KenAJoh KenAJoh deleted the datepicker-default-open branch November 8, 2024 08:38
@github-actions github-actions bot mentioned this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants