Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♿ CopyButton now tells SR what you are copying #3455

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented Dec 12, 2024

Description

Resolves #3450

Component Checklist 📝

  • JSDoc
  • Examples
  • Documentation / Decision Records
  • Storybook
  • Style mappings (@navikt/core/css/config/_mappings.js)
  • Component tokens (@navikt/core/css/tokens.json)
  • CSS class deprecations (@navikt/aksel-stylelint/src/deprecations.ts)
  • Exports (@navikt/core/react/src/index.ts and @navikt/core/react/package.json)
  • New component? CSS import (@navikt/core/css/index.css)
  • Breaking change? Update migration guide. Consider codemod.
  • Changeset (Format: <Component>: <gitmoji?> <Text>. E.g. "Button: ✨ Add feature xyz.")

@KenAJoh KenAJoh requested a review from it-vegard December 12, 2024 12:49
@KenAJoh KenAJoh self-assigned this Dec 12, 2024
Copy link

changeset-bot bot commented Dec 12, 2024

⚠️ No Changeset found

Latest commit: f519fa8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

<CopyButton
copyText={x.name}
title={`${sanitizeName(
x.name.replace("text-", ""),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nå gjør vi samme operasjonen her og på linje 35. Burde vi trukket det ut til en konstant? Ikke viktig, men forhindrer eventuelle forskjeller ved endringer i fremtiden.

Samme gjelder de andre tilfellene lenger nede.

it-vegard
it-vegard previously approved these changes Dec 13, 2024
Copy link
Contributor

@it-vegard it-vegard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser bra ut, og kan merges nå om du ikke vil flytte formattering av tekstene ut i konstanter.

@KenAJoh KenAJoh merged commit 88dc43b into main Dec 13, 2024
3 of 4 checks passed
@KenAJoh KenAJoh deleted the a11y-updated-aksel-dec branch December 13, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Design Tokens - kopier-knappene har ikke unike navn
2 participants