Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Aksel.nav.no] Image comparison module #3473

Merged
merged 9 commits into from
Dec 23, 2024
Merged

[Aksel.nav.no] Image comparison module #3473

merged 9 commits into from
Dec 23, 2024

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented Dec 19, 2024

Description

Adds a new Sanity module for "blogg" articles where you can compare two images with a slider inspired by https://react-compare-slider.vercel.app/?path=/docs/docs-introduction--docs.

Handle follows the "slider"-pattern

  • Arrow left/right changes by 5%
  • Arrow up/down changes by 5%
  • Home/End sets it to 0% or 100%
Screen.Recording.2024-12-19.at.11.28.56.mov
Screenshot 2024-12-19 at 11 29 36

Component Checklist 📝

  • JSDoc
  • Examples
  • Documentation / Decision Records
  • Storybook
  • Style mappings (@navikt/core/css/config/_mappings.js)
  • Component tokens (@navikt/core/css/tokens.json)
  • CSS class deprecations (@navikt/aksel-stylelint/src/deprecations.ts)
  • Exports (@navikt/core/react/src/index.ts and @navikt/core/react/package.json)
  • New component? CSS import (@navikt/core/css/index.css)
  • Breaking change? Update migration guide. Consider codemod.
  • Changeset (Format: <Component>: <gitmoji?> <Text>. E.g. "Button: ✨ Add feature xyz.")

@KenAJoh KenAJoh self-assigned this Dec 19, 2024
Copy link

changeset-bot bot commented Dec 19, 2024

⚠️ No Changeset found

Latest commit: 1f49ca7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@JulianNymark JulianNymark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! 🤩 (also, extra low threshold for accepting stuff to website/*)

@KenAJoh KenAJoh merged commit 1fb7224 into main Dec 23, 2024
4 checks passed
@KenAJoh KenAJoh deleted the image-comparison branch December 23, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants