[aksel.nav.no] Make inert-prop in ShowMore work in React 19 #3497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HalvorHaugan
commented
Jan 9, 2025
| @@ -96,6 +96,8 @@ export const ShowMore = | |||
|
|
|||
| const ChevronIcon = isOpen ? ChevronUpIcon : ChevronDownIcon; | |||
|
|
|||
| const inertValue = parseInt(version.split(".")[0]) > 18 ? true : ""; // Support for inert was added in React 19 | |||
There was a problem hiding this comment.
We could have just hard coded it according to what React version we are using on the website, but I made it dynamic in case we decide to release this as a component in the React package later.
KenAJoh
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this bug when working on Pensjonskalkulator, since they have a copy of this component there. They have just migrated to React 19, which turns out now supports
inertand now "translates" empty string tofalse. So correct value in React 19 istrue.