-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IS-1735: Remove send to arena code which is always toggled off #223
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tssId
fra linje 177 og ned til registerEmottakSubscription
gjøres nå i ArenaDialogmeldingService
via cronjobben, så det kan også fjernes herfra. Det er også en private fun getLoggingMeta()
der som det kanskje går an å bruke hvis det gir mening å dra inn servicen (kanskje ikke?).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, skal se på det!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Så sånn koden i prod er nå så gjøres henting av tssID
og registerEmottakSubscription
både når padm2 prosesserer innkommet melding og i send-til-arena-cronjobben. Fjerner første delen i denne PRen, men er det problematisk at det er sånn i prod nå? cc @JMLindseth @geir-waagboe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushet fjerning av registerEmottakSubscription
fra den synkrone prosesseringen nå, gjorde også no refaktorering av instansiering LoggingMeta
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tror ikke det er noe problem at det er dobbelt opp for øyeblikket
41ad9e1
to
e2e0b4e
Compare
Remove tss and emottaksubscription code from processing Refactor create LoggingMeta Lint fix
bf595bd
to
74bdf9a
Compare
Hva har blitt lagt til✨🌈
Dialogmeldinger sendes nå til Arena via ny cronjob så vi kan slette litt gammel kode 🎉