Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IS-1735: Remove send to arena code which is always toggled off #223

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

andersrognstad
Copy link
Contributor

Hva har blitt lagt til✨🌈

Dialogmeldinger sendes nå til Arena via ny cronjob så vi kan slette litt gammel kode 🎉

@andersrognstad andersrognstad requested a review from a team as a code owner October 27, 2023 12:49
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tssId fra linje 177 og ned til registerEmottakSubscription gjøres nå i ArenaDialogmeldingService via cronjobben, så det kan også fjernes herfra. Det er også en private fun getLoggingMeta() der som det kanskje går an å bruke hvis det gir mening å dra inn servicen (kanskje ikke?).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, skal se på det!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Så sånn koden i prod er nå så gjøres henting av tssID og registerEmottakSubscription både når padm2 prosesserer innkommet melding og i send-til-arena-cronjobben. Fjerner første delen i denne PRen, men er det problematisk at det er sånn i prod nå? cc @JMLindseth @geir-waagboe

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushet fjerning av registerEmottakSubscription fra den synkrone prosesseringen nå, gjorde også no refaktorering av instansiering LoggingMeta.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tror ikke det er noe problem at det er dobbelt opp for øyeblikket

@andersrognstad andersrognstad force-pushed the IS-1735-cleanup-arena-sending branch from 41ad9e1 to e2e0b4e Compare October 30, 2023 14:42
Remove tss and emottaksubscription code from processing

Refactor create LoggingMeta

Lint fix
@andersrognstad andersrognstad force-pushed the IS-1735-cleanup-arena-sending branch from bf595bd to 74bdf9a Compare October 31, 2023 11:02
@andersrognstad andersrognstad merged commit ce9c4b9 into master Oct 31, 2023
3 checks passed
@andersrognstad andersrognstad deleted the IS-1735-cleanup-arena-sending branch October 31, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants